Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Util][NFC] OptimizeIntArithmetic: reduce calls to eraseState #19130

Merged
merged 1 commit into from
Nov 14, 2024
Merged

[Util][NFC] OptimizeIntArithmetic: reduce calls to eraseState #19130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 5 additions & 38 deletions compiler/src/iree/compiler/Dialect/Util/Transforms/OptimizeIntArithmetic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#include "mlir/Pass/PassRegistry.h"
#include "mlir/Transforms/GreedyPatternRewriteDriver.h"

#define DEBUG_TYPE "iree-util-optimize-arithmetic"
#define DEBUG_TYPE "iree-util-optimize-int-arithmetic"
using llvm::dbgs;

using namespace mlir::dataflow;
Expand Down Expand Up @@ -289,43 +289,7 @@ class DataFlowListener : public RewriterBase::Listener {
void notifyOperationErased(Operation *op) override {
s.eraseState(s.getProgramPointAfter(op));
for (Value res : op->getResults())
flushValue(res);
}
void notifyOperationModified(Operation *op) override {
for (Value res : op->getResults())
flushValue(res);
}
void notifyOperationReplaced(Operation *op, Operation *replacement) override {
for (Value res : op->getResults())
flushValue(res);
}

void notifyOperationReplaced(Operation *op, ValueRange replacement) override {
for (Value res : op->getResults())
flushValue(res);
}

void flushValue(Value value) {
SmallVector<Value> worklist;
SmallVector<Value> process;
worklist.push_back(value);

while (!worklist.empty()) {
process.clear();
process.swap(worklist);
for (Value childValue : process) {
auto *state = s.lookupState<IntegerValueRangeLattice>(childValue);
if (!state) {
continue;
}
s.eraseState(childValue);
for (auto user : childValue.getUsers()) {
for (Value result : user->getResults()) {
worklist.push_back(result);
}
}
}
}
s.eraseState(res);
}

DataFlowSolver &s;
Expand Down Expand Up @@ -386,11 +350,14 @@ class OptimizeIntArithmeticPass

FrozenRewritePatternSet frozenPatterns(std::move(patterns));
for (int i = 0;; ++i) {
LLVM_DEBUG(dbgs() << " * Starting iteration: " << i << "\n");
if (failed(solver.initializeAndRun(op))) {
emitError(op->getLoc()) << "failed to perform int range analysis";
return signalPassFailure();
}

LLVM_DEBUG(
dbgs() << " * Finished Running Solver -- Applying Patterns\n");
bool changed = false;
if (failed(applyPatternsAndFoldGreedily(op, frozenPatterns, config,
&changed))) {
Expand Down
Loading