[GPU] Bail out in GPUReduceBankConflicts if we have collapse_shape user #18863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe users Signed-off-by: Nirvedh <nirvedh@gmail.com>
555709f to
5c82292
Compare
qedawkins
reviewed
Oct 21, 2024
compiler/src/iree/compiler/Codegen/Common/GPU/GPUReduceBankConflicts.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/GPU/GPUReduceBankConflicts.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Nirvedh <nirvedh@gmail.com>
Signed-off-by: Nirvedh <nirvedh@gmail.com>
d246351 to
379040c
Compare
Signed-off-by: Nirvedh <nirvedh@gmail.com>
Max191
reviewed
Oct 22, 2024
Comment on lines
+29
to
+30
| if (isa<ViewLikeOpInterface>(user)) { | ||
| for (auto u : user->getUsers()) { |
There was a problem hiding this comment.
Should probably add arith::SelectOp to this too. And ops with a block that has an argument tied to this use should add the block arg users (I think we mainly need to worry about scf.for).
There was a problem hiding this comment.
I think both of these cases should be okay with the pass, as it will add a strided subview with the same shape as the pre padded alloc and replace the type in all the users, the problem with the collapse shape case is it does not support strides that dont add up to the shape.
If there is some IR case you are worried about, happy to add that as a test.
Max191
approved these changes
Oct 24, 2024
Eliasj42
pushed a commit
that referenced
this pull request
Oct 31, 2024
…er (#18863) This is unsupported by upstream and can lead to a compiler error. llvm/llvm-project#112994 Progress towards: #18858 --------- Signed-off-by: Nirvedh <nirvedh@gmail.com> Signed-off-by: Elias Joseph <eljoseph@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unsupported by upstream and can lead to a compiler error. llvm/llvm-project#112994
Progress towards: #18858