Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLVMGPU] Explicitly set configs for vector distribution pipeline lowering tests #18553

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

Groverkss
Copy link
Contributor

This patch does two things:

  • Before this patch, tests in pipeline_vector_distribute.mlir run select-lowering-config as well as the lowering pipeline together. This restricts us from testing lowering for different configs for the same kernel. This patch explicitly sets configuration for kernels in these tests. For configuration, we already have tests in config_vector_distribute.mlir which test kernel config logic for vector distribution.
  • Tests for gfx940 and gfx1100 were in the same file. Since we set kernel configuration explicitly, running a test with a gfx1100 intrinsic with gfx940 test target chip would cause errors. This patch splits these tests into their own files.

@Groverkss Groverkss enabled auto-merge (squash) September 19, 2024 08:30
@Groverkss Groverkss merged commit fa44a32 into main Sep 19, 2024
35 of 36 checks passed
@Groverkss Groverkss deleted the users/Groverkss/fix-vector-distribute-tests branch September 19, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants