[Codegen][CPU] Eliminate all-true vector masks after vectorization #18190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e1fe9a to
6dea91f
Compare
This enables an upstream transform that eliminates all true `vector.create_mask` ops. This is particularly beneficial for scalable vectors, which use dynamic tensor types, which results in masks that otherwise would not fold away till much later, preventing some optimizations. Depends on #99314. Signed-off-by: Benjamin Maxwell <benjamin.maxwell@arm.com>
6dea91f to
9f25223
Compare
Abbreviated Benchmark Summary@ commit 06255e62aec4827e77b30d6aed67f1f158154310 (vs. base c71fe1a7aa8a1c360e6418043b2a1165861d72f9) Data-Tiling Comparison TableClick to show
No improved or regressed benchmarks 🏖️ No improved or regressed compilation metrics 🏖️ For more information: |
|
Thanks! LG, but a test would be nice :) |
28e0d74 to
09525ba
Compare
Done 👍 |
hanhanW
approved these changes
Aug 13, 2024
Comment on lines
+328
to
+334
| /// Converts from iree_compiler::VscaleRange to vector::VscaleRange. | ||
| static std::optional<vector::VscaleRange> | ||
| toVectorVscaleRange(std::optional<iree_compiler::VscaleRange> vscaleRange) { | ||
| if (!vscaleRange.has_value()) | ||
| return std::nullopt; | ||
| return vector::VscaleRange{vscaleRange->min, vscaleRange->max}; | ||
| } |
There was a problem hiding this comment.
I was confused that why can't we just use vector::VscaleRagnge, then I found that it's added to upstream recently (llvm/llvm-project@9b06e25). Can you help remove the IREE version, and switch to use upstream version? It can be done in a follow-up.
There was a problem hiding this comment.
I'll do this in a follow up PR 👍
c-rhodes
approved these changes
Aug 14, 2024
compiler/src/iree/compiler/Codegen/Common/test/generic_vectorization.mlir
Outdated
Show resolved
Hide resolved
Signed-off-by: Benjamin Maxwell <benjamin.maxwell@arm.com>
MacDue
added a commit
to MacDue/iree
that referenced
this pull request
Aug 15, 2024
Quick follow-up to iree-org#18190, as I realized the test may also pass if the conv fails to vectorize.
MacDue
added a commit
to MacDue/iree
that referenced
this pull request
Aug 15, 2024
Quick follow-up to iree-org#18190, as I realized the test may also pass if the conv fails to vectorize. Signed-off-by: Benjamin Maxwell <benjamin.maxwell@arm.com>
MacDue
added a commit
to MacDue/iree
that referenced
this pull request
Aug 15, 2024
Quick follow-up to iree-org#18190, as I realized the test may also pass if the conv fails to vectorize. Signed-off-by: Benjamin Maxwell <benjamin.maxwell@arm.com>
banach-space
pushed a commit
that referenced
this pull request
Aug 15, 2024
…#18218) Follow up to #18190 (comment) Signed-off-by: Benjamin Maxwell <benjamin.maxwell@arm.com>
c-rhodes
pushed a commit
that referenced
this pull request
Aug 15, 2024
Quick follow-up to #18190, as I realized the test may also pass if the conv fails to vectorize. Signed-off-by: Benjamin Maxwell <benjamin.maxwell@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables an upstream transform that eliminates all true
vector.create_maskops. This is particularly beneficial for scalable vectors, which use dynamic tensor types, which results in masks that otherwise would not fold away till much later, preventing some optimizations.Depends on llvm/llvm-project#99314.