Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old TensorFlow Bazel code, docs, and flags. #13437

Merged
merged 6 commits into from
May 10, 2023

Conversation

ScottTodd
Copy link
Member

Follow-up to the work tracked on #13037.

@ScottTodd ScottTodd added infrastructure Relating to build systems, CI, or testing integrations/tensorflow TensorFlow model import and conversion cleanup 🧹 labels May 5, 2023
@ScottTodd ScottTodd marked this pull request as ready for review May 5, 2023 21:13
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @MaheshRavishankar - I'm removing the "Sync everything to a Google/TensorFlow commit" part of these docs. A few other parts of this doc could use a review pass from someone more familiar with the process.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Google commit still actually provides value in that it indicates a commit that has received some amount of testing. For now, it also is necessary to occasionally use these commits for our internal integrations.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can keep some part of the docs, but sections like

sed -i "s/^TENSORFLOW_COMMIT = .*$/TENSORFLOW_COMMIT = \"$TF_COMMIT\"/" integrations/tensorflow/WORKSPACE

are outdated (integrations/tensorflow/WORKSPACE no longer exists)

@ScottTodd ScottTodd requested a review from antiagainst as a code owner May 10, 2023 18:49
@ScottTodd ScottTodd enabled auto-merge (squash) May 10, 2023 21:48
@ScottTodd ScottTodd merged commit 9e80fb0 into iree-org:main May 10, 2023
@ScottTodd ScottTodd deleted the tf-bazel-obsolete branch May 10, 2023 22:12
monorimet pushed a commit to nod-ai/SRT that referenced this pull request May 15, 2023
monorimet pushed a commit to nod-ai/SRT that referenced this pull request May 15, 2023
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 infrastructure Relating to build systems, CI, or testing integrations/tensorflow TensorFlow model import and conversion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants