-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete old TensorFlow Bazel code, docs, and flags. #13437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @MaheshRavishankar - I'm removing the "Sync everything to a Google/TensorFlow commit" part of these docs. A few other parts of this doc could use a review pass from someone more familiar with the process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Google commit still actually provides value in that it indicates a commit that has received some amount of testing. For now, it also is necessary to occasionally use these commits for our internal integrations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can keep some part of the docs, but sections like
sed -i "s/^TENSORFLOW_COMMIT = .*$/TENSORFLOW_COMMIT = \"$TF_COMMIT\"/" integrations/tensorflow/WORKSPACE
are outdated (integrations/tensorflow/WORKSPACE
no longer exists)
Follow-up to the work tracked on iree-org#13037.
Follow-up to the work tracked on iree-org#13037.
Follow-up to the work tracked on iree-org#13037.
Follow-up to the work tracked on #13037.