Skip to content

Commit

Permalink
[Codegen] Rename tuning application test flag (#19816)
Browse files Browse the repository at this point in the history
This flag is intended for tests only. Rename it and mark as it as
hidden.

Requested by @qedawkins in
#19762 (comment).

Issue: #19720

Signed-off-by: Jakub Kuderski <jakub@nod-labs.com>
  • Loading branch information
kuhar authored Jan 25, 2025
1 parent ccb0dea commit 73a6307
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
// RUN: iree-opt --split-input-file --iree-gpu-test-target=gfx942 \
// RUN: --pass-pipeline="builtin.module(hal.executable(hal.executable.variant(iree-hal-configure-target-executable-variants{target=rocm})))" \
// RUN: --iree-codegen-enable-default-tuning-specs \
// RUN: --iree-codegen-notify-transform-strategy-application \
// RUN: --iree-codegen-test-notify-transform-strategy-application \
// RUN: --verify-diagnostics %s | FileCheck %s

// RUN: iree-opt --split-input-file --iree-gpu-test-target=mi300x@hip \
// RUN: --pass-pipeline="builtin.module(hal.executable(hal.executable.variant(iree-hal-configure-target-executable-variants{target=rocm})))" \
// RUN: --iree-codegen-enable-default-tuning-specs \
// RUN: --iree-codegen-notify-transform-strategy-application \
// RUN: --iree-codegen-test-notify-transform-strategy-application \
// RUN: --verify-diagnostics %s | FileCheck %s --check-prefix=MI300X

// Check that the default configuration for mmt_2048x1280x5120_f16_f16_f32
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
// RUN: iree-opt --split-input-file --iree-gpu-test-target=gfx942 \
// RUN: --pass-pipeline="builtin.module(hal.executable(hal.executable.variant(iree-hal-configure-target-executable-variants{target=rocm})))" \
// RUN: --iree-codegen-tuning-spec-path=%p/tuning_spec_mmt_tile_and_fuse.mlir \
// RUN: --iree-codegen-notify-transform-strategy-application \
// RUN: --iree-codegen-test-notify-transform-strategy-application \
// RUN: --verify-diagnostics %s | FileCheck %s

// RUN: iree-opt --split-input-file --iree-gpu-test-target=gfx942 \
// RUN: --pass-pipeline="builtin.module(hal.executable(hal.executable.variant(iree-hal-configure-target-executable-variants{target=rocm})))" \
// RUN: --iree-codegen-tuning-spec-path=%p/tuning_spec_mmt_tile_and_fuse.mlir \
// RUN: --iree-codegen-enable-default-tuning-specs \
// RUN: --iree-codegen-notify-transform-strategy-application \
// RUN: --iree-codegen-test-notify-transform-strategy-application \
// RUN: --verify-diagnostics %s | FileCheck %s

// Make sure we can apply the lowering strategy from the specified tuning spec.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include "iree/compiler/Codegen/Dialect/Codegen/IR/IREECodegenAttrs.h"
#include "iree/compiler/Codegen/Dialect/Codegen/IR/IREECodegenDialect.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/CommandLine.h"
#include "mlir/Dialect/Transform/Transforms/TransformInterpreterUtils.h"
#include "mlir/IR/BuiltinOps.h"
#include "mlir/IR/MLIRContext.h"
Expand All @@ -33,11 +34,11 @@ llvm::cl::opt<std::string> clCodegenTransformDialectLibraryFileName(
llvm::cl::init(""));

llvm::cl::opt<bool> clCodegenNotifyTransformDialectLibraryApplication(
"iree-codegen-notify-transform-strategy-application",
"iree-codegen-test-notify-transform-strategy-application",
llvm::cl::desc(
"Emit a remark when a transform configuration strategy successfully "
"applies on a function. This is intended for testing/debuging."),
llvm::cl::init(false));
llvm::cl::Hidden, llvm::cl::init(false));

#define GEN_PASS_DEF_MATERIALIZEUSERCONFIGSPASS
#include "iree/compiler/Codegen/Common/Passes.h.inc"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
// RUN: iree-opt --pass-pipeline='builtin.module(builtin.module(iree-codegen-materialize-tuning-specs,iree-codegen-materialize-user-configs))' \
// RUN: --iree-codegen-tuning-spec-path=%p/tuning_spec.mlir \
// RUN: --iree-codegen-notify-transform-strategy-application \
// RUN: --iree-codegen-test-notify-transform-strategy-application \
// RUN: --no-implicit-module --verify-diagnostics %s | FileCheck %s

// RUN: iree-opt --pass-pipeline='builtin.module(iree-codegen-materialize-tuning-specs,builtin.module(iree-codegen-materialize-user-configs))' \
// RUN: --iree-codegen-tuning-spec-path=%p/tuning_spec.mlir \
// RUN: --iree-codegen-notify-transform-strategy-application \
// RUN: --iree-codegen-test-notify-transform-strategy-application \
// RUN: --no-implicit-module --verify-diagnostics %s | FileCheck %s --check-prefix=PARENT

// (1) We start by running the `Materialize Tuning Specs` pass to embed the
Expand Down

0 comments on commit 73a6307

Please sign in to comment.