[TKW] set_symbol and apply_expr ops
#382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think you can leave the dispatch codegen as is for now and just pass in a dummy value since it will not be used in the kernel. |
harsh-nod
reviewed
Jan 14, 2025
harsh-nod
reviewed
Jan 15, 2025
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
c9050a8 to
20547ee
Compare
harsh-nod
approved these changes
Jan 15, 2025
| @dataclass | ||
| class SetSymbol(CustomOp): | ||
| symbol: IndexExpr | ||
| register_: fx.Proxy |
There was a problem hiding this comment.
Just wondering why mark these as type fx.Proxy instead of fx.Node?
There was a problem hiding this comment.
Half of the ops are using fx.Proxy intead fx.Node, we should probably align all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_symbolop to set specific symbol to some dynamic value (i.e. read from memory) during codegen, this is mostly a hack until we have a proper support for slices/reductions with dynamic sizes/tilesizes.apply_exprop to allow nontrivial index calculations.