Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tested IREE version to most recent nightly. #354

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

ScottTodd
Copy link
Member

@ScottTodd ScottTodd commented Dec 20, 2024

We're approaching our 3.1.0 release across all IREE packages (iree-org/iree#19192), so testing closer to HEAD.

Commit range: iree-org/iree@iree-3.1.0rc20241212...iree-3.1.0rc20241220

@ScottTodd
Copy link
Member Author

Some TKW tests seem to be stalling on mi250 and mi300 runners: https://github.com/iree-org/iree-turbine/actions/runs/12438563153?pr=354. Might have to debug locally.

cc @raikonenfnu @harsh-nod @Hardcode84

@ScottTodd ScottTodd marked this pull request as draft December 21, 2024 00:03
@ScottTodd
Copy link
Member Author

Yeah jobs are getting stuck consistently. First run wasn't making progress after nearly 2 hours: https://github.com/iree-org/iree-turbine/actions/runs/12438563153/job/34730710267?pr=354#step:7:39.

@Hardcode84
Copy link
Contributor

I will look into it.

@Hardcode84
Copy link
Contributor

https://gist.githubusercontent.com/Hardcode84/dd213d889a1c7a96618bd2bab5c451ca/raw/89681b9add6ab5f0d468aa115c96b83b004142f0/gistfile1.txt

After OptimizeIntArithmeticPass attention loop iteration count is replaced with huge value, causing kernel to hang.

There may be an issue with OptimizeIntArithmeticPass or upstream integer range analysis, I'm looking into it.

CC @krzysz00

@Hardcode84
Copy link
Contributor

Here is the reduced example:

func.func @test3(%6: index) -> index {
  %c64 = arith.constant 64 : index
  %55 = arith.ceildivsi %6, %c64 : index
  return %55 : index
}

mlir-opt --debug-only=int-range-analysis --int-range-optimizations repro.mlir

func.func @test3(%arg0: index) -> index {
  %c144115188075855872 = arith.constant 144115188075855872 : index
  return %c144115188075855872 : index
}

ceildivsi range analysis is very broken

@Hardcode84
Copy link
Contributor

Workaround for the ceildiv bug: #355
Upstream fix: llvm/llvm-project#121062

@ScottTodd
Copy link
Member Author

Workaround for the ceildiv bug: #355 Upstream fix: llvm/llvm-project#121062

Thanks! Looks like the upstream LLVM change hasn't landed in IREE quite yet, so proceeding with the workaround for now SGTM.

Hardcode84 added a commit that referenced this pull request Jan 2, 2025
Integer range inference is broken for `arith.ceildivsi` (see
#354 (comment)),
switch to ceildiv emulation again.

Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@Hardcode84
Copy link
Contributor

Merged the workaround

@ScottTodd ScottTodd marked this pull request as ready for review January 2, 2025 20:48
@ScottTodd
Copy link
Member Author

Got a clean CI run after retrying a few flaky tests/workflows. I'd like to land this then try incrementally updating again.

@ScottTodd ScottTodd merged commit 78fc794 into iree-org:main Jan 2, 2025
10 checks passed
@ScottTodd ScottTodd deleted the iree-version-3.1.0-preview branch January 2, 2025 22:49
ScottTodd added a commit that referenced this pull request Jan 6, 2025
Similar to #354, we're
approaching our 3.1.0 release across all IREE packages
(iree-org/iree#19192), so testing closer to
HEAD.

Changes needed:

* Update `FlatSymbolRefAttr` usage, similar to
nod-ai/shark-ai#732
* Allow the "Test Build Release" workflow to skip failed experimental
release downloads while IREE's macOS compiler release builds are broken
(iree-org/iree#19591)

Commit range:
iree-org/iree@iree-3.1.0rc20241220...iree-3.1.0rc20250103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants