Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'torch' from deps and warn instead #343

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Remove 'torch' from deps and warn instead #343

merged 3 commits into from
Dec 16, 2024

Conversation

marbre
Copy link
Member

@marbre marbre commented Dec 16, 2024

Instead of enforcing the installation for 'torch' as a dependency, error if 'torch' cannot be imported and point the user to how to install.

@marbre
Remove 'torch' from deps and warn instead
df60548 
Instead of enforcing the installation for 'torch' as a dependency, error
if 'torch' cannot be imported and point the user to how to install.
ScottTodd
ScottTodd reviewed Dec 16, 2024
View reviewed changes
setup.py Show resolved Hide resolved
@ScottTodd ScottTodd mentioned this pull request Dec 16, 2024
Merged
ScottTodd
ScottTodd reviewed Dec 16, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
ScottTodd added a commit to iree-org/iree that referenced this pull request Dec 16, 2024
@ScottTodd
[docs] Expand on instructions for installing torch for CPU. (#19493)
f2690e2 
Context:
iree-org/iree-turbine#343 (comment)

Screenshot: 

![image](https://github.com/user-attachments/assets/7643cb54-4283-4de8-b8f5-c49d34efc2e9)
@marbre marbre force-pushed the users/marbre/torch branch from 9f040ff to 17fa603 Compare December 16, 2024 22:10
@marbre marbre force-pushed the users/marbre/torch branch from 17fa603 to f92a826 Compare December 16, 2024 22:13
ScottTodd
ScottTodd approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nit

README.md Show resolved Hide resolved
@marbre @ScottTodd
Update README.md
65f6ce6 
Co-authored-by: Scott Todd <scott.todd0@gmail.com>
@marbre marbre enabled auto-merge (squash) December 16, 2024 22:18
@marbre marbre merged commit fcf600a into main Dec 16, 2024
9 of 10 checks passed
@marbre marbre deleted the users/marbre/torch branch December 16, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottTodd ScottTodd ScottTodd approved these changes

@stellaraccident stellaraccident Awaiting requested review from stellaraccident

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marbre @ScottTodd