[TKW] Add xfail decorator for unaligned shape #163
Conversation
Signed-off-by: Stanley Winata <stanley.winata@amd.com>
tests/kernel/wave/wave_e2e_test.py
Outdated
| @@ -30,8 +30,10 @@ | |||
| ] | |||
|
|
|||
| user_specified_test_shapes = "" | |||
|
|
|||
| test_params_path = os.environ.get("TEST_PARAMS_PATH", None) | |||
| default_filename = "test_param.json" | |||
There was a problem hiding this comment.
Please, don't. We need to make all tests work with default shapes.
The core issue that test_tiled_reduce_max doesn't work with weird shapes, instead of skipping this shape entirely, we need to fix test or mark it xfail.
There was a problem hiding this comment.
Interesting, so what was the motivation for adding test_param.json shapes to begin with?
There was a problem hiding this comment.
The motivation was to run perf test with different set of shapes from CI tests.
There was a problem hiding this comment.
ah, that makes sense, thanks :)
There was a problem hiding this comment.
I left a comment on #119 (comment) . I think pytest marks (for test type / size, as well as xfail) are a better fit here than environment variables and separate json files.
There was a problem hiding this comment.
@Hardcode84 updated the test ,re-review please :)
Signed-off-by: Stanley Winata <stanley.winata@amd.com>
Signed-off-by: Stanley Winata <stanley.winata@amd.com>
Signed-off-by: Stanley Winata <stanley.winata@amd.com>
Signed-off-by: Ian <ian.nordeng@amd.com>
Signed-off-by: Ian <ian.nordeng@amd.com>
No description provided.