reject #[zeroize(drop)] on struct/enum fields, enum variants #847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reject the #[zeroize(drop)] attribute on struct and enum fields, as users may be missing a zeroizing Drop implementation
they expected to be generated for them.
For consistency, the attribute is now rejected on enum variants as well, which was previously accepted and generated a
Drop impl for the entire enum, but which may not be what users may have expected, as it could be interpreted that such
an attribute would zeroize only the variants containing the attribute on Drop.
Closes #837.