Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TC per-lcore tuning #720

Merged
merged 10 commits into from
Apr 15, 2021
Merged

TC per-lcore tuning #720

merged 10 commits into from
Apr 15, 2021

Conversation

ywc689
Copy link
Collaborator

@ywc689 ywc689 commented Mar 10, 2021

  • Refactor TC module to be per-lcore.
  • Fix crash problem when add/modify/del qsch/qcls dynamically with traffic bursting in.
  • Fix inaccuracy traffic control problem of tbf caused by multi-thread contention of tokens.
  • Schedule qsch per loop to make TC work properly.

ywc689 added 5 commits March 10, 2021 15:21
Signed-off-by: ywc689 <ywc689@163.com>
Signed-off-by: ywc689 <ywc689@163.com>
Signed-off-by: ywc689 <ywc689@163.com>
Signed-off-by: ywc689 <ywc689@163.com>
@haosdent
Copy link
Contributor

Would this make QoS usable?

@ywc689
Copy link
Collaborator Author

ywc689 commented Mar 17, 2021

Would this make QoS usable?

Just some simple cases, such as traffic shaping and policing. I'll write a doc to show some use cases later.

@haosdent
Copy link
Contributor

I think, thanks a lot! @ywc689

ywc689 added 2 commits March 18, 2021 13:10
Signed-off-by: ywc689 <ywc689@163.com>
Signed-off-by: ywc689 <ywc689@163.com>
@ywc689 ywc689 force-pushed the tc2 branch 5 times, most recently from 408fbae to 4319a02 Compare March 18, 2021 13:08
Signed-off-by: ywc689 <ywc689@163.com>
@ywc689 ywc689 requested a review from anonymous-zx March 19, 2021 01:29
@ywc689 ywc689 added the pr/to-review-codes review codes line by line and check if problem exists. label Mar 19, 2021
@ywc689 ywc689 added the pr/needs-confirmed the feature in the pr is what we need,and list what cases should be checked in later stages label Mar 19, 2021
@ywc689 ywc689 requested a review from ytwang0320 March 29, 2021 00:53
@@ -266,6 +266,18 @@ static inline int ipv6_addr_cmp(const struct in6_addr *a1, const struct in6_addr
return memcmp(a1, a2, sizeof(struct in6_addr));
}

static inline int ipv6_addr_cmp_u128(const struct in6_addr *a1, const struct in6_addr *a2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is duplicated with the upper one.

@ywc689 ywc689 requested a review from anonymous-zx April 13, 2021 03:51
@ywc689 ywc689 added pr/accepted the pr passed all review stages and await to be merged and removed pr/to-review-codes review codes line by line and check if problem exists. labels Apr 14, 2021
@ywc689 ywc689 merged commit e2bfc75 into iqiyi:devel Apr 15, 2021
@ywc689 ywc689 deleted the tc2 branch April 21, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/accepted the pr passed all review stages and await to be merged pr/needs-confirmed the feature in the pr is what we need,and list what cases should be checked in later stages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants