Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make generated config files more lintable #750

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Jun 17, 2022

c, load_config are injected into the file's namespace, but linters don't know that.

  • avoids c is undefined lint on every config line

  • uses # noqa to avoid lint on the c = load_config() line itself

@minrk minrk added enhancement 5.0-no-incidence change that has noincidence on 5.0 compat (eg: doc) labels Jun 17, 2022
c, load_config are injected into the file namespace,
but linters don't know that

avoids `c is undefined` errors on every config line

uses `# noqa` to avoid lint on the `c = load_config()`  line itself
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0-no-incidence change that has noincidence on 5.0 compat (eg: doc) enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants