Avoid echoing onto a captured FD #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
commented
Apr 24, 2023
minrk
commented
Apr 24, 2023
avoids hang if there's nothing to read could also close first, which would wake the thread, but that gets complicated with the redirect
to avoid messing with pytest output capture I'm pretty sure it's _possible_ to do this in-process, but I can't seem to figure it out
1c5d741 to
a8ddfa1
Compare
|
@minrk thanks for fixing this! lmk how i can help drive this to completion |
assert that the unreachable None case doesn't happen
otherwise, we have no idea why things break
stop closes the event puller socket, but only if start was called
|
Finally got all actual tests to pass! |
blink1073
reviewed
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When echoing output onto stderr, it should be onto the copy, not the redirected FD, so it only goes to the terminal instead of making an infinite loop, echoing and then capturing and then re-echoing the same output.
I've verified that this works, I just need to work out the tests without messing up pytest output itself.
closes #859