pkp/pkp-lib#10970 Fix statuses for review assignments, and use submis…

…sionStageId
ipula · Feb 27, 2025 · 1b2cd0e · 1b2cd0e
1 parent 3c7e1f5
commit 1b2cd0e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/pages/dashboard/components/DashboardTable/DashboardCellReviewAssignmentActions.vue b/src/pages/dashboard/components/DashboardTable/DashboardCellReviewAssignmentActions.vue
@@ -36,7 +36,7 @@ const actionLabel = computed(() => {
 		[
 			pkp.const.WORKFLOW_STAGE_ID_EDITING,
 			pkp.const.WORKFLOW_STAGE_ID_PRODUCTION,
-		].includes(props.item.stageId)
+		].includes(props.item.submissionStageId)
 	) {
 		// It the review assignment is incomplete, show no action
 		// for complete scenario it will fallback to the 'View' below

diff --git a/src/pages/dashboard/composables/useDashboardConfigEditorialActivity.js b/src/pages/dashboard/composables/useDashboardConfigEditorialActivity.js
@@ -409,7 +409,7 @@ export function useDashboardConfigEditorialActivity() {
 			[
 				pkp.const.WORKFLOW_STAGE_ID_EDITING,
 				pkp.const.WORKFLOW_STAGE_ID_PRODUCTION,
-			].includes(reviewAssignment.stageId)
+			].includes(reviewAssignment.submissionStageId)
 		) {
 			// It the review assignment is incomplete
 			if (

diff --git a/src/pages/dashboard/mocks/reviewAssignmentScenariosMock.js b/src/pages/dashboard/mocks/reviewAssignmentScenariosMock.js
@@ -56,13 +56,13 @@ export const ReviewAssignmentEditorialActivityScenario = [
 	getReviewAssignmentFullMock({
 		submissionId: 11,
 		statusId: pkp.const.REVIEW_ASSIGNMENT_STATUS_ACCEPTED,
-		stageId: pkp.const.WORKFLOW_STAGE_ID_PRODUCTION,
+		submissionStageId: pkp.const.WORKFLOW_STAGE_ID_PRODUCTION,
 	}),
 	// When moved to copyediting / production stage
 	// When the review was declined - same indication for declined regardless of the stage
 	getReviewAssignmentFullMock({
 		submissionId: 12,
 		statusId: pkp.const.REVIEW_ASSIGNMENT_STATUS_DECLINED,
-		stageId: pkp.const.WORKFLOW_STAGE_ID_PRODUCTION,
+		submissionStageId: pkp.const.WORKFLOW_STAGE_ID_PRODUCTION,
 	}),
 ];