Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Throw error on resolving non-root path #16

Closed
vmx opened this issue Jul 17, 2018 · 1 comment
Closed

Throw error on resolving non-root path #16

vmx opened this issue Jul 17, 2018 · 1 comment
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now status/ready Ready to be worked

Comments

@vmx
Copy link
Member

vmx commented Jul 17, 2018

When passing in a path like /a/b/c into resolve() there should be an error. Only resolve('/') should be supported.
@vmx vmx added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up labels Jul 17, 2018
@daviddias daviddias added kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked labels Aug 25, 2018
@vmx vmx added P3 Low: Not priority right now and removed P2 Medium: Good to have, but can wait until someone steps up labels Nov 14, 2018
chafey added a commit to chafey/js-ipld-raw that referenced this issue Feb 26, 2020
@chafey
Fix for issue ipld#16 - Throw error on resolving non-root path
37701fc
@chafey chafey mentioned this issue Feb 26, 2020
Merged
chafey added a commit to chafey/js-ipld-raw that referenced this issue Feb 26, 2020
@chafey
fix: issue ipld#16 - Throw error on resolving non-root path
a9da124
chafey added a commit to chafey/js-ipld-raw that referenced this issue Feb 26, 2020
@chafey
fix: issue ipld#16 - Throw error on resolving non-root path
63dc5a4
chafey added a commit to chafey/js-ipld-raw that referenced this issue Feb 26, 2020
@chafey
fix: issue ipld#16 - Throw error on resolving non-root path
703addf
vmx pushed a commit that referenced this issue Feb 27, 2020
@chafey
fix: issue #16 - Throw error on resolving non-root path (#43)
a5b53be 
BREAKING CHANGE: non-root paths throw an error

Prior to this change a call to the resolver with a path like this:

    resolver.resolve(blob, '/a/b/c/d')

would just return the `blob` and an empty remainder path.

With this commit, it will throw an Error as there is no such path.
@vmx
Copy link
Member Author

vmx commented Feb 27, 2020

Closed by #43.

@vmx vmx closed this as completed Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vmx @daviddias