Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Package stable breaks everything after update #65

Closed
kenshyx opened this issue Apr 16, 2018 · 1 comment
Closed

Package stable breaks everything after update #65

kenshyx opened this issue Apr 16, 2018 · 1 comment

Comments

@kenshyx
Copy link

kenshyx commented Apr 16, 2018

After the last release of the package stable they changed the way that module is exported. Now when I'm starting my node I get only errors on this line https://github.com/ipld/js-ipld-dag-pb/blob/master/src/dag-node/create.js#L39:

Uncaught TypeError: sort is not a function
    at Function.create (create.js?803c:39)

This happens because they switched to default export https://github.com/Two-Screen/stable/blob/fbab260b17e0d2d953e18a465d1ca74a3214ae5f/index.d.ts#L2

@kenshyx
Copy link
Author

kenshyx commented Apr 16, 2018

A quick fix would be to use the sort.default

fsdiogo added a commit to fsdiogo/js-ipld-dag-pb that referenced this issue Apr 16, 2018
This PR locks the stable dependecy to a working version, as the latest one breaks all the browser tests.

Fixes ipld#65.
@vmx vmx closed this as completed in #66 Apr 16, 2018
vmx pushed a commit that referenced this issue Apr 16, 2018
This PR locks the stable dependecy to a working version, as the latest one breaks all the browser tests.

Fixes #65.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant