This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
feat: Support the hashLen option of multihashing #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
approved these changes
Oct 13, 2018
There was a problem hiding this comment.
The linting of the commit message failed due to having the uppercase "S". I'll fix this when i merge it.
Your original PR comment contains valuable information on why to do this change, so I'll add it to the commit message. I'm a fan of having detailed commit messages that consist of more than just a single line.
|
@naure thanks for your contribution! |
|
Thanks for your reactivity! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports the creation CIDs of particular sizes using the variable size of multihashes. One use-case is to fit into the 32 bytes word size of Ethereum.