Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

interop testing #40

Merged
merged 1 commit into from
Feb 10, 2017
Merged

interop testing #40

merged 1 commit into from
Feb 10, 2017

Conversation

daviddias
Copy link
Member

seems that borc is not doing things with tags the same way that go-cbor does :(

@daviddias daviddias added the status/in-progress In progress label Feb 10, 2017
@daviddias
Copy link
Member Author

@dignifiedquire deserializing a CID TAG from a go serialized object puts an extra zero byte in the front.

@flyingzumwalt flyingzumwalt mentioned this pull request Feb 10, 2017
Closed
49 tasks
@daviddias daviddias force-pushed the test/interop branch 3 times, most recently from 8455315 to e1d1577 Compare February 10, 2017 08:08
@daviddias
Copy link
Member Author

All good now :)

@daviddias
Copy link
Member Author

daviddias commented Feb 10, 2017 •
edited
Loading

Only missing is browser testing, but that is a aegir-fixtures issue we are having. I need to merge this asap

dignifiedquire
dignifiedquire reviewed Feb 10, 2017
View reviewed changes
test/interop.spec.js Outdated
const objNoLinkJSON = require('./fixtures/obj-no-link.json')

const objWithLinkCBOR = loadFixture(__dirname, '/fixtures/obj-with-link.cbor')
// const objWithLinkJSON = require('./fixtures/obj-with-link.json')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why u no check me?

@daviddias daviddias force-pushed the test/interop branch 2 times, most recently from b68b08e to d96958b Compare February 10, 2017 15:55
@coveralls
Copy link

coveralls commented Feb 10, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-1.5%) to 91.589% when pulling ec5428b on test/interop into 64440a2 on master.

@daviddias daviddias merged commit 71e03eb into master Feb 10, 2017
@daviddias daviddias deleted the test/interop branch February 10, 2017 16:21
@daviddias daviddias removed status/in-progress In progress labels Feb 10, 2017
@rvagg rvagg mentioned this pull request Apr 22, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dignifiedquire dignifiedquire dignifiedquire left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daviddias @coveralls @dignifiedquire