feat: add basic CLI tests using Go Test #9489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guseggert
commented
Dec 9, 2022
guseggert
commented
Dec 9, 2022
89ac9de to
81cd536
Compare
guseggert
commented
Dec 9, 2022
Comment on lines
+49
to
+55
| node.UpdateConfig(func(cfg *config.Config) { | ||
| cfg.Routing.Type = config.NewOptionalString("custom") | ||
| cfg.Routing.Methods = config.Methods{ | ||
| "find-peers": {RouterName: "TestDelegatedRouter"}, | ||
| "find-providers": {RouterName: "TestDelegatedRouter"}, | ||
| "get-ipns": {RouterName: "TestDelegatedRouter"}, | ||
| "provide": {RouterName: "TestDelegatedRouter"}, | ||
| } | ||
| }) |
There was a problem hiding this comment.
Just a side note: this test demonstrates two different ways to get at the config. This way is reading the config file straight from disk, parsing it into a config.Config struct, and then writing the result back to disk. The way below calls the CLI and deals with JSON strings. The config.Config struct is more useful for setting up config for a test, but if you want to test the ability set and read config itself, then use the CLI.
d9c9cd8 to
b7797f0
Compare
fc2e9c3 to
27b49a5
Compare
ajnavarro
reviewed
Dec 12, 2022
9f3d765 to
bf65c09
Compare
bf65c09 to
5f89150
Compare
ajnavarro
reviewed
Dec 12, 2022
5f89150 to
3735602
Compare
ajnavarro
approved these changes
Dec 12, 2022
This is intended as a replacement for sharness. These are vanilla Go tests which can be run in your IDE for quick iteration on end-to-end CLI tests. This also removes IPTB by duplicating its functionality in the test harness. This isn't a big deal...IPTB's complexity is mostly around the fact that its state needs to be saved to disk in between `iptb` command invocations, and that it uses Go plugins to inject functionality, neither of which are relevant here. If we merge this, we'll have to live with bifurcated tests for a while until they are all migrated. I'd recommend we self-enforce a rule that, if we need to touch a sharness test, we migrate it and one more test over to Go tests first. Then eventually we will have migrated everything.
3735602 to
564d260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended as a replacement for sharness. These are vanilla Go tests which can be run in your IDE for quick iteration on end-to-end CLI tests.
This also removes IPTB by duplicating its functionality in the test harness. This isn't a big deal...IPTB's complexity is mostly around the fact that its state needs to be saved to disk in between
iptbcommand invocations, and that it uses Go plugins to inject functionality, neither of which are relevant here.If we merge this, we'll have to live with bifurcated tests for a while until they are all migrated. I'd recommend we self-enforce a rule that, if we need to touch a sharness test, we migrate it and one more test over to Go tests first. Then eventually we will have migrated everything.