Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port CircleCI jobs to GH Actions and improve sharness reporting #9355
feat: port CircleCI jobs to GH Actions and improve sharness reporting #9355
Changes from 65 commits
ca4b95c
c3a64b8
08cba85
f6fbe34
d873053
265cc78
a5a8413
33bb868
abebd9c
9794042
2503b83
78ee0da
0d4af6c
fe1114f
030e819
51f27e9
762d78b
c09a3f2
3927f4d
3ccec00
96a52f7
ca53a7a
8080d30
197d1f9
76b70d4
fd83fc4
20c6396
ba204a9
b9e877c
6c1ecca
97878ae
fb92ce0
ee9503e
35c6a37
c2f5254
bcfc117
fac48ca
f84a0c6
47029ef
7a93014
c5a2788
3a6ce5d
37ea70a
3c2aa36
9f93b12
925ce63
6adb328
34d6a1a
e383874
79f8457
b787b5e
7ac1d8a
d32d816
7db9ea7
7e85c5a
a5148ef
efec414
680edf5
eacac1a
06dca5e
625eb77
72c12c6
65ca877
aa871a2
6d6e006
0c11db6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 a potential concern: our CI will ignore any new suites added to https://github.com/ipfs/interop
@galargh I don't want to block merge on fixing this, but do you mind opening a separate PR that refactors it in a way that ensures we always run all suites (incl. ones added in future)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as https://github.com/ipfs/kubo/pull/9355/files#r1000538616
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I'll change it in a subsequent PR. That way this one will be green when we merge it and
master
will be green after the merge.