Alias 'ipfs --version' to 'ipfs version' #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please introduce sharness test case for it, so if we do refactor of it in future it doesn't get lost. |
|
I'll look into that tonight, thanks! |
|
Thank you, @csasarak! |
License: MIT Signed-off-by: Chris Sasarak <chris.sasarak@gmail.com>
1. Test that ipfs --version has a 0 exit status 2. Check the ipfs --version output matches ipfs version License: MIT Signed-off-by: Chris Sasarak <chris.sasarak@gmail.com>
|
I've added two tests that I could think of, details are in the commit message. |
|
LGTM |
|
SGTM |
| ipfs version > version.txt && | ||
| ipfs --version > version2.txt && | ||
| diff version2.txt version.txt || | ||
| test_fsh ipfs --version |
There was a problem hiding this comment.
Maybe use test_cmp version.txt version2.txt instead of those last two lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #2976. This is a pretty simple method since it looks like the main ipfs command pretty much just parses and launches the others. If you think it is likely that we'll have more 'alias' type things that people will want on ipfs (not its subcommands) in the future, I can probably write something (like a dict) mapping aliases to real commands.