Lets 'ipfs add' include top-level hidden files #2202
Conversation
|
maybe hidden files should act on non-recursive adds too, unless > mkdir /tmp/foo
> cd /tmp/foo
> git init
> touch bar
> echo "bar" >.gitignore
> git add bar
The following paths are ignored by one of your .gitignore files:
foo
Use -f if you really want to add them.nvm |
| return err | ||
| // Iterate over each top-level file and add individually. Otherwise the | ||
| // single files.File f is treated as a directory, affecting hidden file | ||
| // semantics. |
|
Sorry, i'm being silly. this is for hidden files, not for ignored files. |
| @@ -48,6 +48,17 @@ test_add_skip() { | |||
| test_cmp expected actual | |||
| ' | |||
|
|
|||
| test_expect_success "'ipfs add' includes hidden files at the top-level even without --hidden" ' | |||
There was a problem hiding this comment.
maybe say 'ipfs add' includes hidden files given explicitly even without --hidden -- top-level was a bit confusing given the example below (mountdir/dotfiles/.vimrc), took me a second to realize it meant "top level of the commands file tree"
There was a problem hiding this comment.
You're 100% right -- that's pretty confusing. I'll steal yours. :)
|
one way to do the "explicit/direct" thing is to have the commands lib label the files that are added directly vs those added recursively, then the adder can check something like: if f.Explicit() || adder.Hidden { ... } |
|
@noffle comments above, otherwise LGTM. +1 on comments, thank you. |
Happy to have you sell me on it, but I really don't like the idea of the exposing the semantics of how command line processing works to the FileAdder -- I think this sort of "hidden unless an 'explicit' file" notion should live on the outside. What might be nice is it FileAdder exposed a callback func that you could provide that acted like a filter function. Each file calls it (ideally with enough information to infer whether it's top-level/explicit or not), and so those sorts of policy decisions (filter or include) can be made from the outside without polluting the FileAdder. |
|
Oh i understand now-- i was missing that explicitly added single files will always be in top level, obvious in retrospect. |
|
(last thing and good to merge i think! |
|
cool, this LGTM |
That is an excellent requirement. Can do! 🎊 |
Fixes ipfs/go-ipfs/ipfs#2145. The --hidden switch (still) only affects recursive adding. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>
3630977 to
0828d1e
Compare
|
cool cool cool 🚢 |
Lets 'ipfs add' include top-level hidden files
Because this requirement is not listed anywhere, but was mentioned in #2202 (comment). License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
Because this requirement is not listed anywhere, but was mentioned in #2202 (comment). License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
Fixes ipfs/go-ipfs/#2145. The --hidden switch (still) only affects recursive adding.
License: MIT
Signed-off-by: Stephen Whitmore noffle@ipfs.io