-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readonly api to gateway #1389
Closed
Closed
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
988c310
Add readonly api to gateway
travisperson a786cf9
Stripped out excess fmt statement
travisperson 84aaada
Command handlers use whitelist expose commands
travisperson b240796
Updated tests to include the command list
travisperson 7a3337f
Updated other tests and binary's
travisperson 592707d
Added `GatewayAccess` to supplied commands
travisperson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,11 @@ import ( | |
"fmt" | ||
"net/http" | ||
"sync" | ||
"os" | ||
|
||
commands "github.com/ipfs/go-ipfs/commands" | ||
cmdsHttp "github.com/ipfs/go-ipfs/commands/http" | ||
corecommands "github.com/ipfs/go-ipfs/core/commands" | ||
core "github.com/ipfs/go-ipfs/core" | ||
id "github.com/ipfs/go-ipfs/p2p/protocol/identify" | ||
) | ||
|
@@ -25,26 +29,34 @@ func NewGateway(conf GatewayConfig) *Gateway { | |
} | ||
} | ||
|
||
func (g *Gateway) ServeOption() ServeOption { | ||
func (g *Gateway) ServeOption(cctx * commands.Context) ServeOption { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i dont think this is properly |
||
return func(n *core.IpfsNode, mux *http.ServeMux) (*http.ServeMux, error) { | ||
gateway, err := newGatewayHandler(n, g.Config) | ||
if err != nil { | ||
return nil, err | ||
} | ||
mux.Handle("/ipfs/", gateway) | ||
mux.Handle("/ipns/", gateway) | ||
|
||
if cctx != nil { | ||
origin := os.Getenv(originEnvKey) | ||
cmdHandler := cmdsHttp.NewReadOnlyHandler(*cctx, corecommands.Root, origin) | ||
mux.Handle(cmdsHttp.ApiPath+"/", cmdHandler) | ||
} | ||
return mux, nil | ||
} | ||
} | ||
|
||
func GatewayOption(writable bool) ServeOption { | ||
|
||
func GatewayOption(writable bool, cctx * commands.Context) ServeOption { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style fix: i think the |
||
g := NewGateway(GatewayConfig{ | ||
Writable: writable, | ||
BlockList: &BlockList{}, | ||
}) | ||
return g.ServeOption() | ||
return g.ServeOption(cctx) | ||
} | ||
|
||
|
||
func VersionOption() ServeOption { | ||
return func(n *core.IpfsNode, mux *http.ServeMux) (*http.ServeMux, error) { | ||
mux.HandleFunc("/version", func(w http.ResponseWriter, r *http.Request) { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
problem with making two handlers is drift in the implementations.
maybe instead of creating two different handlers, make the original handler always check a list of available commands, and then we can just instantiate the read-only and read-write handlers by passing two different command lists.
that way the
can turn into