Skip to content

Commit

Permalink
Added Default false to all remaining options
Browse files Browse the repository at this point in the history
Specifically, to `repo`, `resolve`, `swarm`, and `version`. Part of #2484.

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
  • Loading branch information
RichardLitt committed May 12, 2016
1 parent a2bcec4 commit f52050d
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions core/commands/repo.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ order to reclaim hard disk space.
`,
},
Options: []cmds.Option{
cmds.BoolOption("quiet", "q", "Write minimal output."),
cmds.BoolOption("quiet", "q", "Write minimal output.").Default(false),
},
Run: func(req cmds.Request, res cmds.Response) {
n, err := req.InvocContext().GetNode()
Expand Down Expand Up @@ -127,7 +127,7 @@ RepoSize int Size in bytes that the repo is currently taking.
res.SetOutput(stat)
},
Options: []cmds.Option{
cmds.BoolOption("human", "Output RepoSize in MiB."),
cmds.BoolOption("human", "Output RepoSize in MiB.").Default(false),
},
Type: corerepo.Stat{},
Marshalers: cmds.MarshalerMap{
Expand Down
2 changes: 1 addition & 1 deletion core/commands/resolve.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Resolve the value of an IPFS DAG path:
cmds.StringArg("name", true, false, "The name to resolve.").EnableStdin(),
},
Options: []cmds.Option{
cmds.BoolOption("recursive", "r", "Resolve until the result is an IPFS name. Default: false."),
cmds.BoolOption("recursive", "r", "Resolve until the result is an IPFS name.").Default(false),
},
Run: func(req cmds.Request, res cmds.Response) {

Expand Down
2 changes: 1 addition & 1 deletion core/commands/swarm.go
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ var swarmAddrsLocalCmd = &cmds.Command{
`,
},
Options: []cmds.Option{
cmds.BoolOption("id", "Show peer ID in addresses."),
cmds.BoolOption("id", "Show peer ID in addresses.").Default(false),
},
Run: func(req cmds.Request, res cmds.Response) {

Expand Down
14 changes: 7 additions & 7 deletions core/commands/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ var VersionCmd = &cmds.Command{
},

Options: []cmds.Option{
cmds.BoolOption("number", "n", "Only show the version number."),
cmds.BoolOption("commit", "Show the commit hash."),
cmds.BoolOption("repo", "Show repo version."),
cmds.BoolOption("number", "n", "Only show the version number.").Default(false),
cmds.BoolOption("commit", "Show the commit hash.").Default(false),
cmds.BoolOption("repo", "Show repo version.").Default(false),
},
Run: func(req cmds.Request, res cmds.Response) {
res.SetOutput(&VersionOutput{
Expand All @@ -47,20 +47,20 @@ var VersionCmd = &cmds.Command{
return strings.NewReader(v.Repo + "\n"), nil
}

commit, found, err := res.Request().Option("commit").Bool()
commit, _, err := res.Request().Option("commit").Bool()
commitTxt := ""
if err != nil {
return nil, err
}
if found && commit {
if commit {
commitTxt = "-" + v.Commit
}

number, found, err := res.Request().Option("number").Bool()
number, _, err := res.Request().Option("number").Bool()
if err != nil {
return nil, err
}
if found && number {
if number {
return strings.NewReader(fmt.Sprintln(v.Version + commitTxt)), nil
}

Expand Down

0 comments on commit f52050d

Please sign in to comment.