Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update Unified CI configuration #386

Merged
merged 2 commits into from
Jul 24, 2023
Merged

ci: update Unified CI configuration #386

merged 2 commits into from
Jul 24, 2023

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Jul 24, 2023

No description provided.

@galargh galargh requested a review from a team as a code owner July 24, 2023 19:02
@welcome
Copy link

welcome bot commented Jul 24, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines
    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

galargh
galargh commented Jul 24, 2023
View reviewed changes
.github/workflows/js-test-and-release.yml
- uses: ipfs/aegir/actions/cache-node-modules@master
- uses: ipfs/aegir/actions/docker-login@master
with:
docker-token: ${{ secrets.DOCKER_TOKEN }}
docker-username: ${{ secrets.DOCKER_USERNAME }}
- run: npm run --if-present release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.UCI_GITHUB_TOKEN || github.token }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SgtPooki With this, we'll be able to set UCI_GITHUB_TOKEN secret to some token that's able to bypass PR reqs (e.g. the ipfs-gui-bot's push token).

@SgtPooki SgtPooki merged commit 549a056 into master Jul 24, 2023
@SgtPooki SgtPooki deleted the web3-bot/sync branch July 24, 2023 19:07
ipfs-gui-bot pushed a commit that referenced this pull request Jul 24, 2023
@semantic-release-bot
chore(release): 4.0.2 [skip ci]
a73e938 
### [4.0.2](v4.0.1...v4.0.2) (2023-07-24)

### Bug Fixes

* url-encoded dag-PB names can be explored ([#384](#384)) ([d5c6899](d5c6899))

### Trivial Changes

* **ci:** checkout with unifiedCI token ([#387](#387)) ([79f09c1](79f09c1))
* **ci:** update Unified CI configuration ([#386](#386)) ([549a056](549a056))
* pull new translations ([#381](#381)) ([a3c67ce](a3c67ce))
* v4.0.1 changelog ([346dc60](346dc60))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtPooki SgtPooki SgtPooki approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galargh @ipfs-gui-bot @SgtPooki @web3-bot