fix(wx): wrap badge update in try block

This solves load error under Chromium Part of #218
ipfs · May 24, 2017 · 176325a · 176325a
1 parent cb6d239
commit 176325a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/add-on/src/lib/common.js b/add-on/src/lib/common.js
@@ -383,15 +383,19 @@ function updateBrowserActionBadge () {
     badgeColor = '#8C8C8C'
     badgeIcon = '/icons/ipfs-logo-off.svg'
   }
-  return setBrowserActionBadge(badgeText, badgeColor, badgeIcon)
+  setBrowserActionBadge(badgeText, badgeColor, badgeIcon)
 }
 
-function setBrowserActionBadge (text, color, icon) {
-  return Promise.all([
-    browser.browserAction.setBadgeBackgroundColor({color: color}),
-    browser.browserAction.setBadgeText({text: text}),
-    browser.browserAction.setIcon({path: icon})
-  ])
+async function setBrowserActionBadge (text, color, icon) {
+  try {
+    await Promise.all([
+      browser.browserAction.setBadgeBackgroundColor({color: color}),
+      browser.browserAction.setBadgeText({text: text}),
+      browser.browserAction.setIcon({path: icon})
+    ])
+  } catch (error) {
+    console.error('Unable to update browserAction badge due to error', error)
+  }
 }
 
 // OPTIONS

diff --git a/add-on/src/popup/browser-action.js b/add-on/src/popup/browser-action.js
@@ -176,7 +176,7 @@ async function activatePinButton () {
 }
 
 async function updatePageActions () {
-  console.log('running updatePageActions()')
+  // console.log('running updatePageActions()')
   try {
     const bg = await getBackgroundPage()
     const currentTab = await getCurrentTab()