This repository has been archived by the owner on Mar 25, 2022. It is now read-only.
Nginx timeouts #104
Merged
Nginx timeouts #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2015 04:56
License: MIT Signed-off-by: Lars Gierth <larsg@systemli.org>
License: MIT Signed-off-by: Lars Gierth <larsg@systemli.org>
|
would this suck if we get DOSed then? or would a request fail early if the ipfs node drops the request (or is down)? |
|
It doesn't make it a lot worse than it already is, I suppose. If I wanted to bring down solarnet, I'd go through port 4001 :) There might be a few things we can do in the gateway code to make it more resilient, e.g. have it check client connection status regularly (client = nginx), and abort actions which originated from a dead connection. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 3dbe4de
Author: Lars Gierth larsg@systemli.org
Date: Fri Oct 23 04:56:54 2015 +0200
commit 4b9dea8
Author: Lars Gierth larsg@systemli.org
Date: Fri Oct 23 05:00:17 2015 +0200