Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Move this repo back into go-ipfs #151

Closed
BigLep opened this issue Oct 28, 2021 · 4 comments · Fixed by ipfs/kubo#8756
Closed

Move this repo back into go-ipfs #151

BigLep opened this issue Oct 28, 2021 · 4 comments · Fixed by ipfs/kubo#8756
Assignees

Comments

@BigLep
Copy link

BigLep commented Oct 28, 2021

Done criteria: this repo's content is moved into ipfs/go-ipfs and this repo is archived/redirected accordingly.
Why important: makes it harder for contributors as have to have PRs often in this repo and ipfs/go-ipfs

@BigLep BigLep added need/triage Needs initial labeling and prioritization and removed need/triage Needs initial labeling and prioritization labels Oct 28, 2021
@lidel lidel changed the title Move this repo into go-ipfs-config Move this repo back into go-ipfs Nov 23, 2021
@aschmahmann
Copy link
Contributor

aschmahmann commented Mar 2, 2022

@hsanjuan do you have any concerns on how this will impact ipfs-cluster?

Generally I think this is a good idea and should be fine. As it is, basically every change to that repo has come from people working on go-ipfs and the repo is pretty tied to go-ipfs. If we feel the need for some backwards compatibility we can always choose to alias the exported types and functions in go-ipfs-config to go-ipfs/config with a deprecation to let people lag behind a little while they update.

@BigLep BigLep moved this to 🔎 In Review in IPFS Shipyard Team Mar 3, 2022
@BigLep BigLep added this to the Best Effort Track milestone Mar 3, 2022
@BigLep
Copy link
Author

BigLep commented Mar 3, 2022

2022-03-03 conversation:

  • Biggest concern is that the quic-go dependency in go-ipfs (which limits the versions of Go that it supports) won't impact the consumers that only have a config dependency on go-ipfs.

@hsanjuan
Copy link
Contributor

hsanjuan commented Mar 4, 2022

@hsanjuan do you have any concerns on how this will impact ipfs-cluster?

I think the project will survive if this is merged back.

Repository owner moved this from 🔎 In Review to ✅ Done in IPFS Shipyard Team Mar 9, 2022
lidel added a commit to ipfs/kubo that referenced this issue Mar 9, 2022
hacdias pushed a commit to ipfs/boxo that referenced this issue Jan 27, 2023
…s-config

Move go-ipfs-config back into go-ipfs,
close ipfs/go-ipfs-config#151

This commit was moved from ipfs/kubo@83b3ec4
hannahhoward pushed a commit to filecoin-project/kubo-api-client that referenced this issue Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants