fix(style): add information to test fail

ipfs · Sep 28, 2021 · 505ed8d · 505ed8d
1 parent f32ba96
commit 505ed8d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/requestmanager/executor/executor.go b/requestmanager/executor/executor.go
@@ -172,6 +172,12 @@ func (e *Executor) onNewBlock(rt RequestTask, block graphsync.BlockData) error {
 
 func (e *Executor) advanceTraversal(rt RequestTask, result types.AsyncLoadResult) error {
 	if result.Err != nil {
+		// before processing result check for context cancel to avoid sending an additional error
+		select {
+		case <-rt.Ctx.Done():
+			return ipldutil.ContextCancelError{}
+		default:
+		}
 		select {
 		case <-rt.Ctx.Done():
 			return ipldutil.ContextCancelError{}

diff --git a/testutil/testutil.go b/testutil/testutil.go
@@ -167,8 +167,8 @@ func VerifySingleTerminalError(ctx context.Context, t TestingT, errChan <-chan e
 	var err error
 	AssertReceive(ctx, t, errChan, &err, "should receive an error")
 	select {
-	case _, ok := <-errChan:
-		require.False(t, ok, "shouldn't have sent second error but did")
+	case secondErr, ok := <-errChan:
+		require.Falsef(t, ok, "shouldn't have sent second error but sent: %s, %s", err, secondErr)
 	case <-ctx.Done():
 		t.Fatal("errors not closed")
 	}