Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for Query.ReturnSizes #34

Closed
MichaelMure opened this issue Nov 22, 2019 · 0 comments · Fixed by #35
Closed

support for Query.ReturnSizes #34

MichaelMure opened this issue Nov 22, 2019 · 0 comments · Fixed by #35

Comments

@MichaelMure
Copy link
Contributor

In ipfs/go-datastore#134 is added a new request field in queries: Query.ReturnSizes.

To honor this field, datastore implementations can either:

  • return the size of the entry in Entry.Size if Query.ReturnSizes is set, or -1 otherwise
  • consider that returning the size doesn't imply a performance cost and always return the size in Entry.Size
MichaelMure added a commit to MichaelMure/go-ds-leveldb that referenced this issue Nov 27, 2019
@MichaelMure
query: always return the size
edc4838 
fix ipfs#34
@MichaelMure MichaelMure mentioned this issue Nov 27, 2019
Merged
Stebalien pushed a commit to MichaelMure/go-ds-leveldb that referenced this issue Dec 3, 2019
@MichaelMure @Stebalien
query: always return the size
5f35650 
fix ipfs#34
Stebalien pushed a commit to MichaelMure/go-ds-leveldb that referenced this issue Dec 3, 2019
@MichaelMure @Stebalien
query: always return the size
d2173d0 
fix ipfs#34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

query: always return the size MichaelMure/go-ds-leveldb
1 participant
@MichaelMure