check error before defer-removing disk usage file

ipfs · Sep 10, 2018 · 5a21fc1 · 5a21fc1
1 parent d25f80d
commit 5a21fc1
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/flatfs.go b/flatfs.go
@@ -864,16 +864,17 @@ func (fs *Datastore) checkpointLoop() {
 func (fs *Datastore) writeDiskUsageFile(du int64, doSync bool) {
 	tmp, err := ioutil.TempFile(fs.path, "du-")
 	removed := false
+	if err != nil {
+		log.Warningf("cound not write disk usage: %v", err)
+		return
+	}
+
 	defer func() {
 		if !removed {
 			// silence errcheck
 			_ = os.Remove(tmp.Name())
 		}
 	}()
-	if err != nil {
-		log.Warningf("cound not write disk usage: %v", err)
-		return
-	}
 
 	toWrite := fs.storedValue
 	toWrite.DiskUsage = du