Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

drop PutMany now that batching exist #4

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

MichaelMure
Copy link

... also, the error used is gone from go-datastore.

This PR is a first step into following the changes in ipfs/go-datastore#134.

However, on top of this compile error with the last go-datastore, the tests still fail with a panic:

...

=== RUN   TestSuite/github.com/ipfs/go-datastore/test.SubtestCombinations/1/{SELECT·keys,vals·FILTER·[KEY·==·"/0key0"]·ORDER·[desc(KEY)]}
=== RUN   TestSuite/github.com/ipfs/go-datastore/test.SubtestCombinations/1/{SELECT·keys,vals·FILTER·[KEY·==·"/0key0"]·ORDER·[desc(KEY)]·OFFSET·10}
panic: runtime error: slice bounds out of range [10:1]

goroutine 3583 [running]:
github.com/ipfs/go-ds-bolt.(*BoltDatastore).Query.func1.1(0xc0000f4460, 0x0, 0x0)
	/home/michael/dev/go-ds-bolt/datastore.go:156 +0x1508
github.com/boltdb/bolt.(*DB).View(0xc0000f0000, 0xc000117ef0, 0x0, 0x0)
	/home/michael/go/pkg/mod/github.com/boltdb/bolt@v1.3.1/db.go:629 +0x14c
github.com/ipfs/go-ds-bolt.(*BoltDatastore).Query.func1(0x6854c0, 0xc000220de0)
	/home/michael/dev/go-ds-bolt/datastore.go:121 +0x169
github.com/jbenet/goprocess.(*process).Go.func1(0xc0000c1b00, 0xc000220de0, 0xc000220e40)
	/home/michael/go/pkg/mod/github.com/jbenet/goprocess@v0.1.3/impl-mutex.go:134 +0x41
created by github.com/jbenet/goprocess.(*process).Go
	/home/michael/go/pkg/mod/github.com/jbenet/goprocess@v0.1.3/impl-mutex.go:133 +0xda

also, the error used is gone from go-datastore
@Stebalien Stebalien merged commit 7d88952 into ipfs:master Dec 3, 2019
@Stebalien
Copy link
Member

Less broken is better than more broken.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants