feat: switch to file io and shrink tables #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Mar 28, 2020
It's actually _faster_ (4x) when reading, on my system. But that may just be because I use BTRFS + SSDs? I'm really not sure.
|
@willscott I further reduced memory by reducing the table size. From what I can tell, this just changes how much data is buffered in memory before flushing. It does not appear to hurt performance (at least on my machine) and significantly reduces memory usage. |
willscott
approved these changes
Mar 28, 2020
This is counter-intuitive, I wonder how much it depends on read patterns. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's actually 4x faster when reading, on my system. But that may just be because I use BTRFS + SSDs? I'm really not sure.