Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Send CANCELs when session context is cancelled #375

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Apr 23, 2020

When the session's context is done, the session sends CANCELs for all pending wants.
However it uses the same (done) context to send the CANCELs, so they never actually get sent.
This PR changes the session to use Bitswap's context to send CANCELs on shutdown.

@Stebalien Stebalien merged commit 26fbfbf into refactor/unref-want-mgr Apr 23, 2020
@Stebalien Stebalien deleted the refactor/sess-ctx-cancels branch April 23, 2020 21:33
@Stebalien
Copy link
Member

Ah, actually, I didn't realize this was against the refactor branch. Could we make another one against master? I want to sneak this into the release as a bugfix but I'd like to leave the refactor out just in case.

@dirkmc
Copy link
Contributor Author

dirkmc commented Apr 23, 2020

Sure I'll make one

@Stebalien
Copy link
Member

Ah, wait, nevermind. It looks like the refactor is really small.

@dirkmc
Copy link
Contributor Author

dirkmc commented Apr 23, 2020

Here it is in case you want it: #376

Jorropo pushed a commit to Jorropo/go-libipfs that referenced this pull request Jan 26, 2023
…ncels

Send CANCELs when session context is cancelled

This commit was moved from ipfs/go-bitswap@26fbfbf
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants