This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Control provider workers with experiment flag #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90773bf to
5543aed
Compare
5543aed to
6785654
Compare
Stebalien
reviewed
May 1, 2019
| // send block off to be reprovided | ||
| case <-bs.process.Closing(): | ||
| return bs.process.Close() | ||
| if ProvideEnabled { |
There was a problem hiding this comment.
Any reason to make this a global flag? That's generally a last resort for things that should only be changed when debugging (or things that absolutely need to apply to the entire program like "force private networks").
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…system-no-blocks Control provider workers with experiment flag This commit was moved from ipfs/go-bitswap@d1f829b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are working on removing the providing behavior from
go-bitswapand putting it into its own module ingo-ipfs. At first the feature will be experimental, and so this commit allows us to disable the provide announcements by settingbitswap.ProvideEnabledtofalsebefore creating bitswap. The default value istrue.