fix(bitswap): simplify SessionInterestManager #821
Merged
+11
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #752
After investigating around 6cd1ed9, I found that
SessionInterestManager
keeping track ofInterested
session, doesn't have a single use case, as @Wondertan suggested.SessionInterestManager
is recording a session'swants
(blocks that we want, and that we didn't get yet), as well asinterests
(block that we want, and we have already).SessionsInterestManager
isn't doing anything about theinterests
, hence I removedinterests
tracking altogether.cc: @gammazero