Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog] fix: Drop stream references on Close/Reset #760

Merged
merged 2 commits into from
Dec 18, 2024

Marco/with after func (#763)

af8522d
Select commit
Loading
Failed to load commit list.
Merged

[skip changelog] fix: Drop stream references on Close/Reset #760

Marco/with after func (#763)
af8522d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 18, 2024 in 0s

60.51% (+0.07%) compared to 2a5c7d0

View this Pull Request on Codecov

60.51% (+0.07%) compared to 2a5c7d0

Details

Codecov Report

Attention: Patch coverage is 79.41176% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.51%. Comparing base (2a5c7d0) to head (af8522d).

Files with missing lines Patch % Lines
bitswap/network/ipfs_impl.go 79.41% 5 Missing and 2 partials ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
+ Coverage   60.43%   60.51%   +0.07%     
==========================================
  Files         245      245              
  Lines       31102    31126      +24     
==========================================
+ Hits        18797    18836      +39     
+ Misses      10630    10619      -11     
+ Partials     1675     1671       -4     
Files with missing lines Coverage Δ
bitswap/network/ipfs_impl.go 79.12% <79.41%> (-2.57%) ⬇️

... and 8 files with indirect coverage changes