fix: return just gateway url if no cid provided

License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
ipfs-shipyard · May 17, 2019 · 98e55d4 · 98e55d4
1 parent cc1c34d
commit 98e55d4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/gateway.js b/src/gateway.js
@@ -1,13 +1,13 @@
 function getGatewayUrl(cid, gatewayProvider = 'ipfs') {
-  if (!cid) {
-    throw new Error('getGatewayUrl expects to be called with a valud IPFS CID')
-  }
   const gateways = {
     ipfs: 'https://ipfs.io',
     infura: 'https://ipfs.infura.io',
     pinata: 'https://gateway.pinata.cloud',
   }
   const origin = gateways[gatewayProvider] || gateways['ipfs']
+  if (!cid) {
+    return origin
+  }
   return `${origin}/ipfs/${cid}`
 }
 

diff --git a/test/gateway.js b/test/gateway.js
@@ -19,8 +19,8 @@ test('get http gateway url for a cid on pinata', t => {
   t.is(actual, expected)
 })
 
-test('throw if no cid', t => {
-  t.throws(() => {
-    httpGatewayUrl()
-  })
+test('get just the http gateway url if no cid', t => {
+  const expected = 'https://ipfs.io'
+  const actual = httpGatewayUrl()
+  t.is(actual, expected)
 })