Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

.cat is not returning a stream anymore #99

Merged
merged 2 commits into from
Nov 2, 2015
Merged

.cat is not returning a stream anymore #99

merged 2 commits into from
Nov 2, 2015

Conversation

daviddias
Copy link
Contributor

#92 introduced a bug where in Node.js, the result no longer comes as a stream. This happened because the .cat test was not properly differentiating between node and browser execution.

This PR is a WIP, the test is now checking correctly the behaviour.

@RichardLitt RichardLitt mentioned this pull request Nov 2, 2015
47 tasks
@dignifiedquire
Copy link
Contributor

Sorry 'bout that. Can you check the other commands to be sure we don't have the same issue somewhere else please?

@victorb
Copy link
Contributor

victorb commented Nov 2, 2015

We do have the same issue elsewhere, what I remember from the top of my
head, findprovs does the same.
On Nov 2, 2015 11:10, "Friedel Ziegelmayer" notifications@github.com
wrote:

Sorry 'bout that. Can you check the other commands to be sure we don't
have the same issue somewhere else please?


Reply to this email directly or view it on GitHub
#99 (comment).

@daviddias
Copy link
Contributor Author

I found it cause for the files API I was explicitly expecting a stream. Still going through this PR

daviddias added a commit that referenced this pull request Nov 2, 2015
.cat is not returning a stream anymore
@daviddias daviddias merged commit b7382d4 into master Nov 2, 2015
@daviddias daviddias deleted the return-streams branch November 2, 2015 16:32
@dignifiedquire
Copy link
Contributor

@diasdavid thanks, you just did what I wasn't able to in my time :)

@daviddias
Copy link
Contributor Author

@dignifiedquire sorry for having gone ahead and make this, I needed for other things and since I remembered you telling me that you would be 'out' for the week, I figured it out. Thank you helping identifying the issue :)

@dignifiedquire
Copy link
Contributor

No worries, happy you did it :)

Thank you helping identifying the issue :)

Well I created it in the first place, so I'd better do :P

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants