This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: pin.ls ignored opts when hash was present #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves problem described in ipfs/ipfs-companion#360 (comment) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
added a commit
to ipfs-inactive/interface-js-ipfs-core
that referenced
this pull request
Oct 21, 2018
Adds tests to guard against issue described in ipfs-inactive/js-ipfs-http-client#875 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Oct 21, 2018
Solves problem described in #360 (comment) by applying fix for ipfs-api from ipfs-inactive/js-ipfs-http-client#875 Closes #360
2 tasks
|
@alanshaw are you able to re-run Jenkins? I don't have permissions :( |
|
Hm.. failing |
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Oct 26, 2018
Solves problem described in #360 (comment) by applying fix for ipfs-api from ipfs-inactive/js-ipfs-http-client#875 Closes #360
alanshaw
approved these changes
Oct 30, 2018
|
Merging because of failing unrelated ping tests |
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Oct 31, 2018
Solves problem described in #360 (comment) by applying fix for ipfs-api from ipfs-inactive/js-ipfs-http-client#875 Closes #360
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Oct 31, 2018
Solves problem described in #360 (comment) by applying fix for ipfs-api from ipfs-inactive/js-ipfs-http-client#875 Closes #360
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Oct 31, 2018
Solves problem described in #360 (comment) by applying fix for ipfs-api from ipfs-inactive/js-ipfs-http-client#875 Closes #360
lidel
added a commit
to ipfs-inactive/interface-js-ipfs-core
that referenced
this pull request
Jul 9, 2019
Adds tests to guard against issue described in ipfs-inactive/js-ipfs-http-client#875 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
alanshaw
pushed a commit
to ipfs-inactive/interface-js-ipfs-core
that referenced
this pull request
Jul 16, 2019
This PR adds more detailed tests for `pin.ls`, including one that guards against issue described in ipfs-inactive/js-ipfs-http-client#875 refs ipfs/js-ipfs#2228 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipfs.pin.lsmay get really slow for mid-large repos, especially when called without executing withopts = {type: recursive}.Unfortunately passing
optsdoes not work right now: it is set to null ifhashis also present.interface-ipfs-coredoes not include proper tests for scenario when bothhashandoptsparams are present, so it was not detected until I tried to use it in ipfs-companion (ipfs/ipfs-companion#360 (comment))This PR fixes the bug by restoring passing of
opts.I add missing test cases to
interface-ipfs-core/js/src/pin/ls.jsin ipfs-inactive/interface-js-ipfs-core#375