Skip to content
This repository has been archived by the owner on Feb 18, 2025. It is now read-only.

RFC: Protocol Messages #1

Merged
merged 32 commits into from
Jun 29, 2020
Merged

RFC: Protocol Messages #1

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
0fc78f2
first draft
Dec 22, 2019
36a01f6
Add table
Dec 22, 2019
726d540
Add protocol version to handshake
Dec 22, 2019
20d31cd
typo
Dec 22, 2019
2745484
Update 0001-protocol-messages.md
Dec 23, 2019
d16a381
Change protocol version to message types
Dec 31, 2019
67c6a81
add type and bitmap->bit array
Jun 9, 2020
2cded03
change message types to protocol version
Jun 9, 2020
a628531
Fix handshake
Jun 9, 2020
a49cdb5
t5b1
Jun 10, 2020
f749826
protocol version up to 32 bytes
Jun 10, 2020
9aa3fe8
fix sentence
Jun 10, 2020
1d4df33
move encoding t5b1 to type
Jun 10, 2020
2eea82d
move encoding t5b1 to type on sig message
Jun 10, 2020
ddd019f
milestone index fix
Jun 10, 2020
911779c
add types and fix heartbeat
Jun 10, 2020
ec6bb4e
fix spelling errors
Jun 10, 2020
b79171f
tx->transaction
Jun 10, 2020
fa44afc
change wording
Jun 10, 2020
443648e
add period
Jun 10, 2020
fa0ec80
relay -> transmitted
Jun 10, 2020
623e295
rmove duplicate word
Jun 10, 2020
69cd6a1
remove STING abbrev
Jun 10, 2020
8540b4f
Transaction Broadcast -> Transaction
Jun 10, 2020
ba787ef
milestone request fix
Jun 10, 2020
3040968
heartbeat
Jun 10, 2020
374ea73
Apply suggestions from code review
GalRogozinski Jun 11, 2020
9b53556
fix timestamp
Jun 11, 2020
47e6fc0
use bullets for consistency
Jun 11, 2020
4de78bb
Update text/0001-protocol-messages/0001-protocol-messages.md
GalRogozinski Jun 16, 2020
4ddb077
Apply suggestions from code review
GalRogozinski Jun 16, 2020
56d9813
remove broadcasts
Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Wolfgang Welz <welzwo@gmail.com>
  • Loading branch information
@GalRogozinski @Wollac
GalRogozinski and Wollac authored Jun 11, 2020
commit 374ea73fbc66652a592e87c8f2139b52ea37a191
17 changes: 8 additions & 9 deletions text/0001-protocol-messages/0001-protocol-messages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,11 @@ Here is a table summarizing all the new message types. The 3-6 types are part of

***STING***

1. Allow for faster syncing by
a. Separating between requests and transaction data.
b. Allowing to request specific milestones by index.
c. Sharing between nodes information on the milestones in their databases via heartbeats.

2. Eliminates fragmentation of request messages. In the legacy gossip messages exceeded TCP's MTU of 1,500 bytes, meaning all gossip transmissions were fragmented by TCP to two packets. Now at least the transaction requests won't be fragmented. Transaction messages are still fragmented unfortunately.
- Allow for faster syncing by
- Separating between requests and transaction data.
- Allowing to request specific milestones by index.
- Sharing between nodes information on the milestones in their databases via heartbeats.
- Eliminates fragmentation of request messages. In the legacy gossip messages exceeded TCP's MTU of 1,500 bytes, meaning all gossip transmissions were fragmented by TCP to two packets. Now, at least the transaction requests will not be fragmented. Transaction messages are still fragmented unfortunately.



Expand Down Expand Up @@ -107,7 +106,7 @@ Requests a milestones by the index. Expects to receive in response the milestone

#### Transaction

Broadcasts the transaction trytes with a 5 trits to a byte encoding. Doesn't expect any message in return. The size remains dynamic to due to signature message compaction.
Broadcasts the transaction trytes with a 5 trits to a byte encoding. Does not expect any message in return. The size remains dynamic to due to signature message compaction.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Broadcasts ?



| Order | Description | Type | Length (bytes) |
Expand All @@ -121,5 +120,5 @@ The heartbeat message will be sent to the peers every time the node solidifies o

|Order | Description | Type | Length (bytes) |
| ---- | ------------------ | ------------------- | ------------- |
| 1 | Last solid milestone index | uint32 (Big Endian) | 4 (Big Endian) |
| 2 | First solid milestone index | unit32 (Big Endian) | 4 (Big Endian)|
| 1 | Last solid milestone index | uint32 (Big Endian) | 4 |
| 2 | First solid milestone index | unit32 (Big Endian) | 4 |