Mana vector fixes #2396
Merged
Mana vector fixes #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/core/notarization/manager.go
karimodm
approved these changes
Aug 25, 2022
|
|
||
| return weights, totalWeight | ||
| } | ||
|
|
||
| // SnapshotEpochActivity returns the activity log for snapshotting. | ||
| func (c *CManaWeightProvider) SnapshotEpochActivity() (epochActivity epoch.SnapshotEpochActivity) { | ||
| func (c *CManaWeightProvider) SnapshotEpochActivity(epochDiffIndex epoch.Index) (epochActivity epoch.SnapshotEpochActivity) { | ||
| epochActivity = epoch.NewSnapshotEpochActivity() | ||
|
|
||
| c.mutex.Lock() | ||
| defer c.mutex.Unlock() | ||
|
|
||
| for ei, al := range c.activityLog { | ||
| al.SetEpochs.ForEach(func(nodeID identity.ID) error { |
There was a problem hiding this comment.
Instead of having ActivityLog exposing an AdvanceSet, can we create a ForEach on the activity record itself while unexporting the AdvancedSet itself?
There was a problem hiding this comment.
Now I use ForEach, but it turned out that I cannot unexport SetEpochs as the serialization stops working
karimodm
suggested changes
Aug 25, 2022
karimodm
reviewed
Aug 29, 2022
karimodm
reviewed
Aug 29, 2022
…a-vector-update-fixes
karimodm
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manaDelayparameter only from mana plugin. Update mana vector event has now only EI.lastConfirmed-activeEpochThreshold