-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bootstrap manager. #2326
Add bootstrap manager. #2326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Just a few minor comments.
type dependencies struct { | ||
dig.In | ||
|
||
Tangle *tangle.Tangle | ||
NotarizationMgr *notarization.Manager | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are those needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dependencies
are needed to create an instance of the Manager
by calling newManager
function. This is handled internally by dig
library. pluginDeps
is needed so that we can call pluginDeps.BootstrapManager.Setup()
in the configure
method. If I put it in pluginDeps
as a parameter to newManager
, it caused a cyclic dependency or something and didn't work.
Description of change
Add bootstrap manager that keeps track of bootstrap status of tangle and notarization manager and triggers an event when both are bootstrapped.
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Add an
x
to the boxes that are relevant to your changes, and delete any items that are not.