Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TSC to compare tangle time with time of confirmed message. #2167

Merged
merged 29 commits into from
Jun 21, 2022
Merged

Update TSC to compare tangle time with time of confirmed message. #2167

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
c55372c
Update TSC to compare tangle time with time of confirmed message.
piotrm50 Apr 21, 2022
26c5485
Fix unit tests
piotrm50 Apr 21, 2022
f35a32a
Change TSC threshold to 1 minute
piotrm50 Apr 21, 2022
87b2a84
Return values explicitly.
piotrm50 May 21, 2022
7d9fec4
Merge branch 'develop' into feat/tsc-update
georgysavva May 23, 2022
5c8c286
New time concepts (#2193)
georgysavva May 23, 2022
c231414
Use refactored time manager.
piotrm50 May 24, 2022
46a02b0
Merge branch 'develop' into feat/tsc-update
piotrm50 Jun 1, 2022
991e02a
Fix merge problems
piotrm50 Jun 1, 2022
06f45a8
Activate tests?
piotrm50 Jun 1, 2022
c807905
Merge remote-tracking branch 'origin/develop' into feat/tsc-update
piotrm50 Jun 2, 2022
4074b10
Merge branch 'develop' into feat/tsc-update
piotrm50 Jun 7, 2022
aa4fe56
Fix unit test
piotrm50 Jun 7, 2022
0b7074c
Merge remote-tracking branch 'origin/develop' into feat/tsc-update
piotrm50 Jun 9, 2022
1620093
Add different tangle times to dashboard and update their naming.
piotrm50 Jun 10, 2022
cc7a546
Update pkged.go
piotrm50 Jun 10, 2022
7bfd7b0
Further improve tangle times on dashboard
piotrm50 Jun 10, 2022
f5e08dc
Fix tangle time naming.
piotrm50 Jun 13, 2022
0e1e0ae
Make integration tests more stable.
piotrm50 Jun 15, 2022
363561d
Fix imports
piotrm50 Jun 15, 2022
34a2a37
Merge remote-tracking branch 'origin/develop' into feat/tsc-update
piotrm50 Jun 17, 2022
8927e1a
Add clarifying comment and improve code readability
jonastheis Jun 20, 2022
0ca4f61
Address review comments.
piotrm50 Jun 21, 2022
33c2f6d
Remove tips older than TSC
piotrm50 Jun 21, 2022
ce651a4
Merge remote-tracking branch 'origin/develop' into feat/tsc-update
piotrm50 Jun 21, 2022
77727b1
Update pkged.go
piotrm50 Jun 21, 2022
c234482
Apply suggestions from code review
piotrm50 Jun 21, 2022
0bf67b7
Fix build
piotrm50 Jun 21, 2022
4097ec8
Update activity window for consensus mana
piotrm50 Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use refactored time manager.
  • Loading branch information
@piotrm50
piotrm50 committed May 24, 2022
commit c23141430c9af08d67b772ae1cee8c3416dbfdcd
2 changes: 1 addition & 1 deletion packages/tangle/timemanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,8 @@ func (t *TimeManager) updateTime(messageID MessageID) {
MessageTime: message.IssuingTime(),
ConfirmedTime: time.Now(),
}
t.updateSyncedState()
})
t.updateSyncedState()
}

// RCTT return relative confirmed tangle time.
Expand Down
2 changes: 1 addition & 1 deletion packages/tangle/tipmanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ func (t *TipManager) Tips(p payload.Payload, countParents int) (parents MessageI
}

func (t *TipManager) isPastConeTimestampCorrect(messageID MessageID) (timestampValid bool) {
minSupportedTimestamp := t.tangle.TimeManager.Time().Add(-t.tangle.Options.TimeSinceConfirmationThreshold)
minSupportedTimestamp := t.tangle.TimeManager.CTT().Add(-t.tangle.Options.TimeSinceConfirmationThreshold)
timestampValid = true

// skip TSC check if no message has been confirmed to allow attaching to genesis
Expand Down