Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added new data structure to the Markers that allows to lookup the referencing Markers of child Sequences + fixed panic #1136

Merged
merged 28 commits into from
Mar 27, 2021

Conversation

hmoog
Copy link
Contributor

@hmoog hmoog commented Mar 26, 2021

Description of change

To be able to traverse the Sequence DAG in both directions, we introduced a new data structure that allows us to query the referencing Markers.

At the same time, this PR fixes a panic that appeared in some rare edge casses.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@hmoog hmoog marked this pull request as draft March 26, 2021 12:31
@hmoog hmoog changed the title Feat: Added ChildReferences in marker.Sequences to be able to jump to the referencing Markers Feat: Added new data structure to the Markers that allows to lookup the referencing Markers of child Sequences. Mar 26, 2021
@hmoog hmoog marked this pull request as ready for review March 27, 2021 00:28
@hmoog hmoog changed the title Feat: Added new data structure to the Markers that allows to lookup the referencing Markers of child Sequences. Feat: Added new data structure to the Markers that allows to lookup the referencing Markers of child Sequences + fixed panic Mar 27, 2021
@capossele capossele merged commit 4e1ed8e into develop Mar 27, 2021
@capossele capossele deleted the feat/childReferences branch March 27, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants