Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/Object Storage #1106

Merged
merged 18 commits into from
Mar 29, 2021
Merged

Docs/Object Storage #1106

merged 18 commits into from
Mar 29, 2021

Conversation

daria305
Copy link
Contributor

@daria305 daria305 commented Mar 22, 2021

Description of change

Docs for object storage
Renderd

Type of change

Documentation

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@daria305 daria305 requested review from piotrm50 and apenzk March 22, 2021 08:07
Copy link
Contributor

@capossele capossele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some examples, e.g., how we use it, Consume, Release

docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
daria305 and others added 14 commits March 23, 2021 10:48
Co-authored-by: Ching-Hua (Vivian) Lin <jkrvivian@gmail.com>
Co-authored-by: Ching-Hua (Vivian) Lin <jkrvivian@gmail.com>
Co-authored-by: Ching-Hua (Vivian) Lin <jkrvivian@gmail.com>
Co-authored-by: Ching-Hua (Vivian) Lin <jkrvivian@gmail.com>
Co-authored-by: Ching-Hua (Vivian) Lin <jkrvivian@gmail.com>
Co-authored-by: Ching-Hua (Vivian) Lin <jkrvivian@gmail.com>
Co-authored-by: Ching-Hua (Vivian) Lin <jkrvivian@gmail.com>
Co-authored-by: Ching-Hua (Vivian) Lin <jkrvivian@gmail.com>
Co-authored-by: Ching-Hua (Vivian) Lin <jkrvivian@gmail.com>
Co-authored-by: Andreas Penzkofer <36140574+apenzk@users.noreply.github.com>
Co-authored-by: Ching-Hua (Vivian) Lin <jkrvivian@gmail.com>
@daria305 daria305 requested a review from apenzk March 26, 2021 07:58
@apenzk apenzk added the docs label Mar 26, 2021
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
docs/implementation_design/object_storage.md Outdated Show resolved Hide resolved
Co-authored-by: Ching-Hua (Vivian) Lin <jkrvivian@gmail.com>
@daria305 daria305 merged commit 972041d into develop Mar 29, 2021
@daria305 daria305 deleted the docs/object-storage branch March 29, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants