Fix: TransactionLiked did not consider monotonicity (#1148)

Co-authored-by: Hans Moog <hm@mkjc.net>
iotaledger · Mar 29, 2021 · abe0e69 · abe0e69
1 parent dc8b79f
commit abe0e69
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/packages/consensus/fcob/consensusmechanism.go b/packages/consensus/fcob/consensusmechanism.go
@@ -61,8 +61,16 @@ func (f *ConsensusMechanism) Setup() {
 
 // TransactionLiked returns a boolean value indicating whether the given Transaction is liked.
 func (f *ConsensusMechanism) TransactionLiked(transactionID ledgerstate.TransactionID) (liked bool) {
-	f.storage.Opinion(transactionID).Consume(func(opinion *Opinion) {
-		liked = opinion.OpinionEssence.liked
+	f.tangle.LedgerState.TransactionMetadata(transactionID).Consume(func(transactionMetadata *ledgerstate.TransactionMetadata) {
+		f.tangle.LedgerState.BranchDAG.Branch(transactionMetadata.BranchID()).Consume(func(branch ledgerstate.Branch) {
+			if !branch.MonotonicallyLiked() {
+				return
+			}
+
+			f.storage.Opinion(transactionID).Consume(func(opinion *Opinion) {
+				liked = opinion.OpinionEssence.liked
+			})
+		})
 	})
 
 	return