Add EPT reader support to read_lidar function #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended the read_lidar function to support 'ept.json' file types by recognizing the EPT reader. Also included a new 'bounds' parameter for spatial cropping and streamlined the pipeline building process for better maintenance. Updated tests to match the new validation error message.
Allow the `poly` parameter to accept either a file path or directly a WKT string for defining the polygon geometry used in cropping. This enhancement simplifies user input by recognizing and processing WKT strings directly.
Change the term from Frequency Histogram Diversity to Foliage Height Diversity for clarity. Enhanced function documentation to better explain the input parameters and the output format while highlighting areas with no voxel returns resulting in NaN values.
64486b3 to
0c2d65e
Compare
This change updates the version of the pyforestscan package to 0.1.7. The increment signifies minor improvements or fixes in the package.
Simplified the validation logic for polygon input when cropping to a polygon. Now, the code clearly separates the responsibilities of checking for provided polygons and verifying file existence, improving readability and maintainability.
These changes ensure that the reprojection filter correctly identifies the input SRS with the `in_srs` parameter. Additionally, specifying `minor_version` in the output step aligns the format with expected versioning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the read_lidar function to support 'ept.json' file types by recognizing the EPT reader. Also included a new 'bounds' parameter for spatial cropping and streamlined the pipeline building process for better maintenance. Updated tests to match the new validation error message.
ref: #8