Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more requirement to be installed on OS X. #184

Merged
merged 1 commit into from
Nov 24, 2015

Conversation

ronkorving
Copy link

This stops NPM from refusing to install ios-sim on an OS other than OS X.

Right now I have a project where ios-sim is a dev-dependency, but developers on Linux can't even npm install the project now, because package.json's os field is preventing NPM from considering it a successful installation. I think the timing of that decision should be at runtime, not install time. Consider also that there may be people who want to install dependencies on Windows or Linux, and package the whole project, before using it on OSX.

The fact that there is no C/C++/ObjC code whatsoever in ios-sim shows that this can be installed on any platform without a problem.

This stops NPM from refusing to install ios-sim on an OS
other than OS X.
@axit-joost
Copy link

+1

shazron added a commit that referenced this pull request Nov 24, 2015
No more requirement to be installed on OS X.
@shazron shazron merged commit d6873f5 into ios-control:master Nov 24, 2015
@shazron
Copy link

shazron commented Nov 24, 2015

Merged and published as 5.0.4

@ronkorving
Copy link
Author

Much appreciated! :)

@ronkorving ronkorving deleted the no-os-check branch November 24, 2015 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants